[pve-devel] [PATCH installer 0/7] refactor; improve installation progress

Christoph Heiss c.heiss at proxmox.com
Wed Jul 26 16:03:54 CEST 2023

First 5 patches splits out the gigantic install progress dialog into its
own module; then applying some divide-and-conquer to make it more
readable and get the inner >150 lines closure down to a more
maintainable state.

Patch 6 does some code de-duplication for the low-lever installer.

Patch 7 improves the auto-reboot message/UX by counting down the
timeout, to match its GUI counterpart.

Christoph Heiss (7):
  tui: move install progress dialog into own view module
  tui: install progress: split out low-level installer spawing into own
  tui: install progress: split out reboot handling into own function
  tui: install progress: split out prompt logic into own function
  tui: install progress: handle errors in ui message loop more
  low-level: avoid open-coding config reading, parsing and merging
  low-level, tui: count down auto-reboot timeout

 proxmox-low-level-installer                   |  70 +++--
 proxmox-tui-installer/src/main.rs             | 235 +--------------
 .../src/views/install_progress.rs             | 275 ++++++++++++++++++
 proxmox-tui-installer/src/views/mod.rs        |   3 +
 4 files changed, 318 insertions(+), 265 deletions(-)
 create mode 100644 proxmox-tui-installer/src/views/install_progress.rs


More information about the pve-devel mailing list