[pve-devel] [PATCH manager v1 3/4] subscription/summary/backup: stop setting the background color

Stefan Sterz s.sterz at proxmox.com
Wed Mar 8 17:40:08 CET 2023


setting the background color in js code adds that property as a style
attribute to the element. that makes it hard to alter later via css
and makes it hard to dynamically change the color e.g. if we want to
add different themes. the background color for these elements are
white already anyway, so just remove them here.

Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
---
 www/manager6/node/Subscription.js   | 1 -
 www/manager6/node/Summary.js        | 1 -
 www/manager6/window/BackupConfig.js | 1 -
 3 files changed, 3 deletions(-)

diff --git a/www/manager6/node/Subscription.js b/www/manager6/node/Subscription.js
index 3b53c7e2..5ca36d42 100644
--- a/www/manager6/node/Subscription.js
+++ b/www/manager6/node/Subscription.js
@@ -40,7 +40,6 @@ Ext.define('PVE.node.Subscription', {
 	    itemId: 'system-report-view',
 	    scrollable: true,
 	    style: {
-		'background-color': 'white',
 		'white-space': 'pre',
 		'font-family': 'monospace',
 		padding: '5px',
diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js
index 320f2247..03512d70 100644
--- a/www/manager6/node/Summary.js
+++ b/www/manager6/node/Summary.js
@@ -18,7 +18,6 @@ Ext.define('PVE.node.Summary', {
 	    id: 'pkgversions',
 	    padding: 5,
 	    style: {
-		'background-color': 'white',
 		'white-space': 'pre',
 		'font-family': 'monospace',
 	    },
diff --git a/www/manager6/window/BackupConfig.js b/www/manager6/window/BackupConfig.js
index ca61b1e4..48649efc 100644
--- a/www/manager6/window/BackupConfig.js
+++ b/www/manager6/window/BackupConfig.js
@@ -10,7 +10,6 @@ Ext.define('PVE.window.BackupConfig', {
 	itemId: 'configtext',
 	autoScroll: true,
 	style: {
-	    'background-color': 'white',
 	    'white-space': 'pre',
 	    'font-family': 'monospace',
 	    padding: '5px',
-- 
2.30.2






More information about the pve-devel mailing list