[pve-devel] [PATCH manager v1 4/4] ui: make ceph charts change color more dynamically

Stefan Sterz s.sterz at proxmox.com
Wed Mar 8 17:40:09 CET 2023


add support for setting the background and text color via css. also
allows for dynamically switching the color when a theme change is
detected.

Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
---
 www/manager6/ceph/StatusDetail.js  | 35 +++++++++++++++++++++++++++++-
 www/manager6/panel/RunningChart.js | 29 +++++++++++++++++++++++++
 2 files changed, 63 insertions(+), 1 deletion(-)

diff --git a/www/manager6/ceph/StatusDetail.js b/www/manager6/ceph/StatusDetail.js
index 88b1775c..d6c0763b 100644
--- a/www/manager6/ceph/StatusDetail.js
+++ b/www/manager6/ceph/StatusDetail.js
@@ -199,6 +199,18 @@ Ext.define('PVE.ceph.StatusDetail', {
 	},
     ],
 
+    checkThemeColors: function() {
+	let me = this;
+	let rootStyle = getComputedStyle(document.documentElement);
+
+	// get color
+	let background = rootStyle.getPropertyValue("--pwt-panel-background").trim() || "#ffffff";
+
+	// set the colors
+	me.chart.setBackground(background);
+	me.chart.redraw();
+    },
+
     updateAll: function(metadata, status) {
 	let me = this;
 	me.suspendLayout = true;
@@ -257,7 +269,7 @@ Ext.define('PVE.ceph.StatusDetail', {
 	    me.statecategories[result].states.push(state);
 	});
 
-	me.getComponent('pgchart').getStore().setData(me.statecategories);
+	me.chart.getStore().setData(me.statecategories);
 	me.getComponent('pgs').update({ states: pgs_by_state });
 
 	let health = status.health || {};
@@ -303,5 +315,26 @@ Ext.define('PVE.ceph.StatusDetail', {
 	me.suspendLayout = false;
 	me.updateLayout();
     },
+
+     initComponent: function() {
+	var me = this;
+	me.callParent();
+
+	me.chart = me.getComponent('pgchart');
+	me.checkThemeColors();
+
+	// switch colors on media query changes
+	me.mediaQueryList = window.matchMedia("(prefers-color-scheme: dark)");
+	me.themeListener = (e) => { me.checkThemeColors(); };
+	me.mediaQueryList.addEventListener("change", me.themeListener);
+    },
+
+    doDestroy: function() {
+	let me = this;
+
+	me.mediaQueryList.removeEventListener("change", me.themeListener);
+
+	me.callParent();
+    },
 });
 
diff --git a/www/manager6/panel/RunningChart.js b/www/manager6/panel/RunningChart.js
index 19db8b50..d89a6ecb 100644
--- a/www/manager6/panel/RunningChart.js
+++ b/www/manager6/panel/RunningChart.js
@@ -98,6 +98,20 @@ Ext.define('PVE.widget.RunningChart', {
     // show the last x seconds default is 5 minutes
     timeFrame: 5*60,
 
+    checkThemeColors: function() {
+	let me = this;
+	let rootStyle = getComputedStyle(document.documentElement);
+
+	// get color
+	let background = rootStyle.getPropertyValue("--pwt-panel-background").trim() || "#ffffff";
+	let text = rootStyle.getPropertyValue("--pwt-text-color").trim() || "#000000";
+
+	// set the colors
+	me.chart.setBackground(background);
+	me.chart.valuesprite.setAttributes({ fillStyle: text }, true);
+	me.chart.redraw();
+    },
+
     addDataPoint: function(value, time) {
 	let view = this.chart;
 	let panel = view.up();
@@ -156,5 +170,20 @@ Ext.define('PVE.widget.RunningChart', {
 		stroke: me.color,
 	    });
 	}
+
+	me.checkThemeColors();
+
+	// switch colors on media query changes
+	me.mediaQueryList = window.matchMedia("(prefers-color-scheme: dark)");
+	me.themeListener = (e) => { me.checkThemeColors(); };
+	me.mediaQueryList.addEventListener("change", me.themeListener);
+    },
+
+    doDestroy: function() {
+	let me = this;
+
+	me.mediaQueryList.removeEventListener("change", me.themeListener);
+
+	me.callParent();
     },
 });
-- 
2.30.2






More information about the pve-devel mailing list