[pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system

Lukas Wagner l.wagner at proxmox.com
Tue Jul 18 16:07:11 CEST 2023

On 7/18/23 15:58, Dominik Csapak wrote:
>> I already have patches laying around that implement the additional filter matchers, but
>> decided to not include them in the patch series yet. Before the new matchers are merged,
>> I would need to 'stabilize' the properties associate with every single notification event,
>> as at that point those become part of our public facing API. At the moment, the properties
>> are only an implementation detail that is used for rendering notification templates.
>> This is also the reason why the filter implementation (filter.rs) is somewhat overkill
>> atm for _just_ severity filtering. Everything needed for these advanced features is already
>> in place - because I already implemented that stuff and cut it out later for the patch series.
> ah ok, so the mode is currently unused.
> one of my questions remains though, does it make sense to configure a filter without
> any filtering properties? i guess not really

Yes, I guess a filter without any matchers does not make much sense. I could add a check
that ensures that at least one is configured - making the min-severity matcher required  for now, as there
are not any other matchers.


- Lukas

More information about the pve-devel mailing list