[pve-devel] applied: [PATCH pve_installer v3] tui: don't abort install if min ram requirement is not met

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 13 16:06:38 CEST 2023

Am 10/07/2023 um 11:22 schrieb Noel Ullreich:
> If the minimum requirements are not met, the TUI installer will create a
> popup notifying you that the install might not work and then exits the
> installer.
> While the GUI also creates such a popup, it will not exit the installer.
> This patch adapts the behavior of the GUI: the TUI creates a popup
> warning you that min spec is not met but doesn't abort the install.
> Signed-off-by: Noel Ullreich <n.ullreich at proxmox.com>
> ---
> changes from v1:
> * moved the min ram check into `installer_setup_late`
> * fixed spelling in the subject line
> changes from v2:
> * fixed formatting
> * removed unnecessary `installer_setup_late` call
>  proxmox-tui-installer/src/main.rs   | 13 +++++++++++--
>  proxmox-tui-installer/src/system.rs | 14 +-------------
>  2 files changed, 12 insertions(+), 15 deletions(-)

applied, with a context merge conflict resolved and total_memory folded into
the if expression directly, as proposed by Christoph when reviewing v2, as with
his patch for central hvm-support applied previously we now have a owned "state"
available, thanks!

More information about the pve-devel mailing list