[pve-devel] [PATCH pve_installer v3] tui: don't abort install if min ram requirement is not met

Christoph Heiss c.heiss at proxmox.com
Mon Jul 10 11:48:44 CEST 2023


LGTM.

On Mon, Jul 10, 2023 at 11:22:27AM +0200, Noel Ullreich wrote:
> If the minimum requirements are not met, the TUI installer will create a
> popup notifying you that the install might not work and then exits the
> installer.
> While the GUI also creates such a popup, it will not exit the installer.
> This patch adapts the behavior of the GUI: the TUI creates a popup
> warning you that min spec is not met but doesn't abort the install.
>

Reviewed-by: Christoph Heiss <c.heiss at proxmox.com>
Tested-by: Christoph Heiss <c.heiss at proxmox.com>
> Signed-off-by: Noel Ullreich <n.ullreich at proxmox.com>
> ---
> changes from v1:
> * moved the min ram check into `installer_setup_late`
> * fixed spelling in the subject line
>
> changes from v2:
> * fixed formatting
> * removed unnecessary `installer_setup_late` call
>
>  proxmox-tui-installer/src/main.rs   | 13 +++++++++++--
>  proxmox-tui-installer/src/system.rs | 14 +-------------
>  2 files changed, 12 insertions(+), 15 deletions(-)
>
> [..]





More information about the pve-devel mailing list