[pve-devel] [PATCH manager 1/2] ui: backup: replication: replace non-clickable checkbox with Yes/No text
Lukas Wagner
l.wagner at proxmox.com
Fri Jan 20 12:17:11 CET 2023
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
---
www/manager6/dc/Backup.js | 7 ++-----
www/manager6/grid/Replication.js | 8 ++++----
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 9d305984..284fead7 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -784,12 +784,9 @@ Ext.define('PVE.dc.BackupView', {
{
header: gettext('Enabled'),
width: 80,
- dataIndex: 'enabled',
- xtype: 'checkcolumn',
+ dataindex: 'enabled',
+ renderer: Proxmox.Utils.format_boolean,
sortable: true,
- disabled: true,
- disabledCls: 'x-item-enabled',
- stopSelection: false,
},
{
header: gettext('ID'),
diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
index b17288b9..18f273d4 100644
--- a/www/manager6/grid/Replication.js
+++ b/www/manager6/grid/Replication.js
@@ -279,11 +279,11 @@ Ext.define('PVE.grid.ReplicaView', {
me.columns = [
{
- text: gettext('Enabled'),
- dataIndex: 'enabled',
- xtype: 'checkcolumn',
+ header: gettext('Enabled'),
+ width: 80,
+ dataindex: 'enabled',
+ renderer: Proxmox.Utils.format_boolean,
sortable: true,
- disabled: true,
},
{
text: 'ID',
--
2.30.2
More information about the pve-devel
mailing list