[pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with Yes/No text

Lukas Wagner l.wagner at proxmox.com
Fri Jan 20 12:17:10 CET 2023


Consider this an RFC to maybe spark up a discussion about this. 

In our UI, we've been a bit inconsistent with the use of checkboxes/text
for `enabled` properties in table views. Looking through the UI, I've
found that the following UI elements use a checkbox UI control to
indicate wheter something is enabled or not:

 * backup job overview
 * APT repository overview
 * replication job overview

While looking sleek, the problem with this is that from a user's
perspective, a checkbox generally implies that it is operable by
clicking on it (which we allow in other places, to make the matter even
more confusing). Now, for the three UI elements mentioned above, I would 
say it is a good thing that they are not manipulateable from the overview,
in order to avoid any accidental modifications.

My suggestion would be, and this is what I've included in this patch
series, to replace those checkboxes with Yes/No text. This is the way
how it is done in many other places of the system.

If we want something prettier, we could replace/augment the text with some
fa-icon, e.g. a check-mark or an X - the important part is that they are
visually distinct from ExtJS's checkboxes.

Note: Firewall configuration also uses a checkbox, however there it is
possible to enable/disable elements by clicking on the checkbox - so
this can stay as IMHO.

pve-manager:

Lukas Wagner (1):
  ui: backup: replication: replace non-clickable checkbox with Yes/No
    text

 www/manager6/dc/Backup.js        | 7 ++-----
 www/manager6/grid/Replication.js | 8 ++++----
 2 files changed, 6 insertions(+), 9 deletions(-)

proxmox-widget-toolkit:

Lukas Wagner (1):
  repo view: replace non-clickable checkbox with Yes/No text

 src/node/APTRepositories.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.30.2






More information about the pve-devel mailing list