[pve-devel] [PATCH manager v3 0/6] fix #1408: ui: make tree sorting configurable

Dominik Csapak d.csapak at proxmox.com
Wed Feb 22 08:51:46 CET 2023


this series allows configuring the sorting of the resource tree

options are the sort-field, if guest types are grouped and if templates
are grouped seperately. it's configurable via browser local storage

the first 2 patches are not really related but popped up during
development

changes from v2:
* improved browser local storage notice
* added padding between the view selector and the button

changes from v1:
* drop the datacenter config options for now
* rename TreeSortingEdit into TreeSortingEdit
* since we don't have a fallback besides the default, display the
  defauls in the dropdowns
* don't use booleanfield anymore (because of above change)
* rename sp into localStorage
* use fieldDefaults
* refactor stuff into PVE.UIOptions (a new singleton)
* remove storage view
* remove booleanfield()

Dominik Csapak (6):
  ui: remove 'Storage View'
  ui: remove unused booleanfield
  ui: refactor ui option related methods into UIOptions
  ui: refactor refreshing the the resource store/tree
  ui: add window for changing tree related options
  fix #1408: ui: ResourceTree: sort the tree according to tree-sorting
    options

 www/manager6/Makefile                   |   3 +-
 www/manager6/UIOptions.js               | 107 ++++++++++++++++++++++++
 www/manager6/Utils.js                   |  92 +-------------------
 www/manager6/Workspace.js               |  29 ++++++-
 www/manager6/data/ResourceStore.js      |   2 +-
 www/manager6/dc/OptionView.js           |  23 ++---
 www/manager6/form/Boolean.js            |  10 ---
 www/manager6/form/GlobalSearchField.js  |   2 +-
 www/manager6/form/Tag.js                |   6 +-
 www/manager6/form/TagColorGrid.js       |   2 +-
 www/manager6/form/TagEdit.js            |  10 +--
 www/manager6/form/ViewSelector.js       |   7 --
 www/manager6/tree/ResourceTree.js       |  56 ++++++++++---
 www/manager6/window/TreeSettingsEdit.js |  87 +++++++++++++++++++
 14 files changed, 290 insertions(+), 146 deletions(-)
 create mode 100644 www/manager6/UIOptions.js
 delete mode 100644 www/manager6/form/Boolean.js
 create mode 100644 www/manager6/window/TreeSettingsEdit.js

-- 
2.30.2






More information about the pve-devel mailing list