[pve-devel] [PATCH proxmox-acme 2/2] tests: add non-word boundary to present functions

Stoiko Ivanov s.ivanov at proxmox.com
Tue Feb 21 14:13:18 CET 2023


noticed that _clearaccountconf_mutable is used in dns_cf.sh, but not
present (it gets masked since we provide _clearaccountconf)

tested with this example.

additionally update missing-functions.expected - _error is not
present in upstream `acme.sh` but used in dns_aws.sh (I expect an
error which is only hit very seldomly)

Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
 src/test/check-missing-functions    | 4 ++--
 src/test/missing-functions.expected | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/test/check-missing-functions b/src/test/check-missing-functions
index cb819fc..dfc32d3 100755
--- a/src/test/check-missing-functions
+++ b/src/test/check-missing-functions
@@ -3,11 +3,11 @@
 set -e
 
 # functions already in src/proxmox-acme
-PRESENT=$(awk 'BEGIN{ORS="|";} /^_/{ gsub(/\(\) {/, ""); print $0}' \
+PRESENT=$(awk 'BEGIN{ORS="\\W|";} /^_/{ gsub(/\(\) {/, ""); print $0}' \
 	../proxmox-acme | sed -r 's/\|$//')
 
 # functions defined in all plugins
-LOCAL=$(awk 'BEGIN{ORS="|";} /^_/{ gsub(/\(\) {/, ""); print $0}' \
+LOCAL=$(awk 'BEGIN{ORS="\\W|";} /^_/{ gsub(/\(\) {/, ""); print $0}' \
 	../acme.sh/dnsapi/dns*.sh | sed -r 's/\|$//')
 
 grep -P '(?<!["$])\b_[a-zA-Z0-9_-]+ ' ../acme.sh/dnsapi/dns_*sh | \
diff --git a/src/test/missing-functions.expected b/src/test/missing-functions.expected
index 467f9ac..5c2b053 100644
--- a/src/test/missing-functions.expected
+++ b/src/test/missing-functions.expected
@@ -1,3 +1,4 @@
+../acme.sh/dnsapi/dns_aws.sh:      _error "invalid domain"
 ../acme.sh/dnsapi/dns_cpanel.sh:  for _domain in $_domains; do
 ../acme.sh/dnsapi/dns_cyon.sh:  printf "%s" "${_dns_entries}" | while read -r _hash _identifier; do
 ../acme.sh/dnsapi/dns_do.sh:      for _rrid in ${_rr_list}; do
-- 
2.30.2






More information about the pve-devel mailing list