[pve-devel] [PATCH v2 container 3/4] lxc: Add `link-down` config to allow setting interfaces as disconnected

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Feb 20 13:37:37 CET 2023


Am 20/02/2023 um 13:33 schrieb Wolfgang Bumiller:
>>> I assumed that, that's why I asked if keeping it that way would help to reuse some
>>> code infra; not sure about how useful it is to keep it for API consumers to keep it
>>> the same as in a quite different API end point,
>> There really is no code-reuse between those two endpoints, so it made
>> sense to me too to rename it.
> It's more about possible code reuse in front-ends rather than in the
> backend though, where a set of common options with common code to
> fill/read/... them can definitely be a thing 😉

fwiw, it won't matter for any of our front ends either, the CT and VM network
API is way to different to share full (edit) panels.

But, for automation tooling that talks with the API it might be quite relevant.

> 
>>> but I see where you come from and don't
>>> insist for going with snake-case, so if you think using the same style here has benefits.
>>> we can ignore the guidance that new params should always use kebab-case.
>> .. but I will rename it back to snake_case for v3, since that seems to
>> be consensus here?
> Given Thomas' plan to rename stuff in the future, I'd say yes, for now.

fine by me, snake_case it is for now, for this specific option.




More information about the pve-devel mailing list