[pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage

Fiona Ebner f.ebner at proxmox.com
Mon Dec 18 14:07:48 CET 2023

Am 18.12.23 um 13:02 schrieb Hannes Dürr:
> On 12/14/23 15:23, Fiona Ebner wrote:
>> create_base() will tell you the actual name, you should not override it
>> with the old one. We expect it to match, but then there's no need for
>> the assignment. If it doesn't match, you'd be returning something wrong.
>> Or what am I missing?
> If i am not mistaken there is the case:
> Plugin           current imagename    action
> lvmthin:        base-100-disk-1         old_base =
> LVMplug:  -> vm-100-disk-1            not working due to collision
> LVMplug:  -> vm-100-disk-2            call find_free_disk()
> lvmthin    -> base-100-disk-2          != old_base

But in this case, returning old_base, i.e. base-100-disk-1, is wrong,
because that is not what the image is actually called. You would need to
additionally rename the image in LVM, but I don't think that's worth it.

More information about the pve-devel mailing list