[pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage

Hannes Dürr h.duerr at proxmox.com
Mon Dec 18 13:02:33 CET 2023

On 12/14/23 15:23, Fiona Ebner wrote:
> create_base() will tell you the actual name, you should not override it
> with the old one. We expect it to match, but then there's no need for
> the assignment. If it doesn't match, you'd be returning something wrong.
> Or what am I missing?
If i am not mistaken there is the case:

Plugin           current imagename    action

lvmthin:        base-100-disk-1         old_base =

LVMplug:  -> vm-100-disk-1            not working due to collision

LVMplug:  -> vm-100-disk-2            call find_free_disk()

lvmthin    -> base-100-disk-2          != old_base

But I think we could also just skip this case and remove the 
$oldbasename completly.

More information about the pve-devel mailing list