[pve-devel] [PATCH v2 guest-common 3/3] abstract config: fix snapshot needed by replication check

[Fiona Ebner]

Do not pass the cleanup flag to get_replicatable_volumes() which leads
to replicatable volumes that have the replicate setting turned off to
be part of the result.

Instead pass the noerr flag, because things like missing the
storage-level replicate feature should not lead to an error here.

Reported in the community forum:
https://forum.proxmox.com/threads/120910/post-605574

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---

New in v2.

 src/PVE/AbstractConfig.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm
index a286b13..5d5f9b4 100644
--- a/src/PVE/AbstractConfig.pm
+++ b/src/PVE/AbstractConfig.pm
@@ -862,7 +862,7 @@ my $snapshot_delete_assert_not_needed_by_replication = sub {
     my $storecfg = PVE::Storage::config();
 
     # Current config's volumes are relevant for replication.
-    my $volumes = $class->get_replicatable_volumes($storecfg, $vmid, $conf, 1);
+    my $volumes = $class->get_replicatable_volumes($storecfg, $vmid, $conf, 0, 1);
 
     my $replication_jobs = $repl_conf->list_guests_local_replication_jobs($vmid);
 
-- 
2.39.2