[pve-devel] [PATCH widget-toolkit] i18n: mark strings as translatable

Dominik Csapak d.csapak at proxmox.com
Wed Dec 6 15:26:29 CET 2023

On 12/6/23 15:04, Maximiliano Sandoval wrote:
> Dominik Csapak <d.csapak at proxmox.com> writes:
>> it's more like DHCP, SLAAC or IPv4. those are names of protocols (like ACME)
>> that shouldn't change across translations
>> and we removed those gettexts (mostly) a while ago
>> e.g. see lxc/Network.js in pve-manager:
>> ---8<---
>> boxLabel: 'DHCP', // do not localize
>> --->8---
> Do note the following examples:

yeah i said we didn't remove all of those instances
and it seems there are some not so good translations still existing.
(bad translations are not a good argument for translating even
more of them? I'd argue they are even an argument that we should
reduce them)

>      #: pve-manager/www/manager6/qemu/IPConfigEdit.js:97
>      #: pve-manager/www/manager6/qemu/IPConfigEdit.js:155
>      msgid "DHCP"
>      msgstr "بروتوكول التهيئة الآلية للمضيفين (DHCP)"

Does not really make sense IMO to translate this, since
DHCP already is an established abbreviation and there
is no need to write it out localized.

>      #: pve-manager/www/manager6/qemu/IPConfigEdit.js:163
>      msgid "SLAAC"
>      msgstr "Autoconfiguration SLAAC"

IMHO this makes even less sense, SLAAC
already includes 'autoconfiguration', so why do this?

>      #: pve-manager/www/manager6/ceph/CephInstallWizard.js:476
>      msgid "First Ceph monitor"
>      msgstr "أول جهاز مراقبة"

doesn't mention ceph in the translation at all....
(which it should!)

> What would be the purpose of removing the translation of the words
> themselves if they are already being translated elsewhere.

none of the examples here translate the words in a meaningful manner,
should be either already known, mentioned in the docs, or be
easily searchable online.
also it only causes issues when using an overly long text
in a field label


> --
> Maximiliano

honestly i don't want to argue/bikeshed about such a small detail,
but i don't see a good reason to translate names and established
(technical) words.

I'm ready to change my mind, but i did not see a good example
of when it would be good to translate 'ACME' (or DHCP, Ceph, etc.)
into something different yet.

More information about the pve-devel mailing list