[pve-devel] [PATCH guest-common] replication: avoid passing removed storages to target

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Aug 30 11:27:07 CEST 2023


Am 23/06/2023 um 12:08 schrieb Fiona Ebner:
> +    # filter out left-over non-existing/removed storages - avoids error on target
> +    $state->{storeid_list} = [ grep { $storecfg->{ids}->{$_} } $state->{storeid_list}->@* ];

looks fine in general, just wondering if we'd be better of to make
the grep include-condition a bit more explicit by using `exists` on
the hash:

$state->{storeid_list} = [ grep { exists $storecfg->{ids}->{$_} } $state->{storeid_list}->@* ];

albeit, the value should be always truthy, so might be redundant,
depending on how you see this I can apply this patch or a v2.





More information about the pve-devel mailing list