[pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content

Thomas Lamprecht t.lamprecht at proxmox.com
Sat Apr 22 09:21:36 CEST 2023

On 20/04/2023 10:06, Dominik Csapak wrote:
> this enables the user to sort the grid by multiple columns
> simultaneously, e.g. by vmid and then by date
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> sending as rfc because i'm not so sure about this.
> on one hand, this allows to recreate the original sorting if users want
> that, but the selection is a bit weird. there is no way to 'unsort'

the original sorting was strange and confusing, while it would be
at least not as confusing with the columns shown it's IMO just not
a good fit for a simple grid.

If we want to make this better, we should adopt a tree view, Fiona
even made a patch for that IIRC, either when she reworked the content
view or when adding group pruning in Proxmox VE (we definitively
talked about doing that off list, the patch might be imagination —
didn't check). Albeit tree views and sorting are naturally not the
greatest thing, an configurable "group by VMID" checkbox could be the
most flexible variant (meaning most edge cases and probabky code too..)

> columns again, it simply uses the last 3 columns that were clicked
> especially with the last patch (statefulness) it becomes weird, but
> maybe we want this more than we want it to be stateful?

tbh. I want neither ;-) At least the chosen full-grid stateful way,
see reply to respective patch.

More information about the pve-devel mailing list