[pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content

Aaron Lauterer a.lauterer at proxmox.com
Thu Apr 20 15:39:37 CEST 2023

I tried the series including this patch and yeah... sorting becomes very 
unpredicatable and weird. AFAICT it also depends on which order the last 3 
columns are selected.

The old behavior was that it was first sorted by VMID and then within the VMID 
by date right?
Is there a way to group by row property in ExtJS grids?

I personally would probably not use this patch.

On 4/20/23 10:06, Dominik Csapak wrote:
> this enables the user to sort the grid by multiple columns
> simultaneously, e.g. by vmid and then by date
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> sending as rfc because i'm not so sure about this.
> on one hand, this allows to recreate the original sorting if users want
> that, but the selection is a bit weird. there is no way to 'unsort'
> columns again, it simply uses the last 3 columns that were clicked
> especially with the last patch (statefulness) it becomes weird, but
> maybe we want this more than we want it to be stateful?
>   www/manager6/storage/BackupView.js | 1 +
>   1 file changed, 1 insertion(+)
> diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
> index bb045f5b6..ebc476747 100644
> --- a/www/manager6/storage/BackupView.js
> +++ b/www/manager6/storage/BackupView.js
> @@ -5,6 +5,7 @@ Ext.define('PVE.storage.BackupView', {
>       showColumns: ['name', 'notes', 'protected', 'date', 'format', 'size'],
> +    multiColumnSort: true,
>       stateful: true,
>       stateId: 'storage-backup-content',

More information about the pve-devel mailing list