[pve-devel] applied: [PATCH widget-toolkit] form: combo grid: use correct method to initialize the picker

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 12 13:46:20 CEST 2023

Am 31/03/2023 um 12:04 schrieb Dominik Csapak:
> 'createPicker' does create the picker, but not all necessary
> initialization for the combobox (namely it does not set the owner field,
> but that's only an implementation detail). Instead 'getPicker' should be
> used for that, since that does all the necessary initialization and is
> the same function used when trying to open it.
> Without this patch, we leak the picker that was created with this
> call every time a combogrid is created.
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  src/form/ComboGrid.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied, but reworded to clarify that the actual issue was that the created
picker was not saved to the field's me.picker state variable (which the
field's doDestroy checks for), thanks!

More information about the pve-devel mailing list