[pve-devel] applied: [PATCH manager] fix #4627: ui: backup edit: don't deselect all vms on load

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 12 13:28:40 CEST 2023


Am 31/03/2023 um 12:03 schrieb Dominik Csapak:
> 'selectPoolMembers' will be called when the poolid field changes.
> (That can even happen when the mode is not even 'pool')
> Due to how the fields are set, there is a race condition that this
> will be called after the remaining fields were set up, including
> the vm list that might have entires selected.
> 
> Since the first thing we do here is to deselect all, this wiped
> the vm selection sometimes.
> 
> To fix it, check if we're actually in the correct mode before doing
> anything.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/manager6/dc/Backup.js | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
>

applied, thanks!





More information about the pve-devel mailing list