[pve-devel] applied: Re: [PATCH v2 guest-common] replication: avoid "expected snapshot missing" warning when irrelevant

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Sep 26 11:27:17 CEST 2022


On 23/09/2022 10:16, Fiona Ebner wrote:
> Only print it when there is a snapshot that would've been removed
> without the safeguard. Mostly relevant when a new volume is added to
> an already replicated guest.
> 
> Fixes replication tests in pve-manager.
> 
> Fixes: c0b2948 ("replication: prepare: safeguard against removal if expected snapshot is missing")
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> Changes from v1:
>     * Only warn when other snapshot would be removed without the
>       safeguard, not just when no other snapshot is present.
> 
>  src/PVE/Replication.pm | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list