[pve-devel] [PATCH qemu-server v3 0/3] qmeventd: improve shutdown behaviour

Dominik Csapak d.csapak at proxmox.com
Fri Sep 23 10:30:07 CEST 2022


includes the following improvements:
* increases 'force cleanup' timeout to 60s (from 5)
* saves individual timeout for each vm
* don't force cleanup for vms where normal cleanup worked
* sending QMP quit instead of SIGTERM (less log noise)

changes from v2:
* change from cast of the function to cast of the parameters
* don't copy the variable on the stack in 'sigkill'

changes from v1:
* remove 'alarm' calls altogether and use epoll_waits' timeout mechanic
   instead
* call 'time()' only once and give it as user data to the function
* change the function singatures and cast on callsite with '(GFunc)'
   for the g_slist_foreach calls
* change to <s> for the usage output for timeouts


Dominik Csapak (3):
  qmeventd: rework 'forced_cleanup' handling and set timeout to 60s
  qmeventd: cancel 'forced cleanup' when normal cleanup succeeds
  qmeventd: send QMP 'quit' command instead of SIGTERM

 qmeventd/qmeventd.c | 118 +++++++++++++++++++++++++++-----------------
 qmeventd/qmeventd.h |   2 +
 2 files changed, 75 insertions(+), 45 deletions(-)

-- 
2.30.2






More information about the pve-devel mailing list