[pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard

[Thomas Lamprecht]

On 19/09/2022 11:16, Fiona Ebner wrote:
> People sometimes expect to select the storage for the VM's disk first.
> This should make the context clearer.
> 
> Suggested in the community forum:
> https://forum.proxmox.com/threads/75219/post-498758
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>  www/manager6/qemu/CDEdit.js | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
> index fc7a59cc..f409fa53 100644
> --- a/www/manager6/qemu/CDEdit.js
> +++ b/www/manager6/qemu/CDEdit.js
> @@ -76,6 +76,13 @@ Ext.define('PVE.qemu.CDInputPanel', {
>  	    items.push(me.bussel);
>  	}
>  
> +	if (me.insideWizard) {
> +	    items.push({
> +		xtype: 'displayfield',
> +		value: `${gettext('Installation media')}:`,
> +	    });
> +	}
> +
>  	items.push({
>  	    xtype: 'radiofield',
>  	    name: 'mediaType',

Bit torn on this one, otoh it's small and might help some, otoh I think that
it shouldn't be required  - there's OS in the tab title already and a disk tab
two steps ahead, that paired with the fact that there's clearly written "CD/DVD
drive" so it should be pretty easy to understand, and if not that extra hint
isn't probably adding that much of extra info over the existing cues, also note,
and here I'm probably over analysing/nit-picking, but it doesn't necesarrily
needs to be a installation media, e.g. for a live distro.

The heading fits somewhat with the one from the OS type selector, so from a purely
layout POV it would be fine to have. Maybe just some other wording, like a plain/
technical "Virtual CD/DVD Drive".

Anyhow, I just take such "just add yet another cue and it would be 101% straight
forward for anybody" like things rather with a grain of salt, as there def. are
quite some existing cues and such proposal are quite subjective (like the "just
that single feature and project XYZ will be Just Perfect™), need to let this ripe
a bit, maybe I'll merge it as is (that is, if you don't send another v2 due to some
agreement here in my ramblings or another, better idea)