[pve-devel] [PATCH/RFC manager 2/2] ui: qemu: CD edit: make label for storage more descriptive

[Thomas Lamprecht]

On 19/09/2022 11:16, Fiona Ebner wrote:
> Namely, use "ISO storage" instead of "Storage". Relevant when inside
> the wizard, to avoid any confusion, but doesn't really feel wrong in
> the normal edit window either.
> 
> Suggested in the community forum:
> https://forum.proxmox.com/threads/75219/post-498758
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> I feel like the first patch might already be enough, but this would
> drive home the point.

Something like that could be OK in general, but a nit could be that the
selector isn't really limited to images in ISO format, so this could actually
add more confusion than it might resolve, IMO doing just the label is more than
enough, this UX confusion didn't came up _that_ often to classify it as issue
for a significant amount of users (still good to improve it for those that are
affected, as it's mostly first time users, which may be overloaded with a new
project)  

> 
>  www/manager6/qemu/CDEdit.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
> index f409fa53..33c12d43 100644
> --- a/www/manager6/qemu/CDEdit.js
> +++ b/www/manager6/qemu/CDEdit.js
> @@ -118,7 +118,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
>  	me.cdstoragesel = Ext.create('PVE.form.StorageSelector', {
>  	    name: 'cdstorage',
>  	    nodename: me.nodename,
> -	    fieldLabel: gettext('Storage'),
> +	    fieldLabel: gettext('ISO storage'),
>  	    labelAlign: 'right',
>  	    storageContent: 'iso',
>  	    allowBlank: false,