[pve-devel] [PATCH container] fix #4192: add new architecture-dependent path to check for newer versions of systemd

[Dominik Csapak]

On 9/12/22 11:30, Dominik Csapak wrote:
> [snip]
>>>   # non systemd based containers work with pure cgroupv2
>>>   sub unified_cgroupv2_support {
>>> -    my ($self) = @_;
>>> +    my ($self, $conf) = @_;
>>
>> why pass the whole config if you just need the arch? Please avoid overly generic
>> parameter in signatures if only one specific thing is required.
>>
> 
> AFAICS, not even that is necessary, since a 'LXC::Setup' object has the config in self
> so we could do there a '$self->{confg}->{arch}' and omit the parameter passing completely

i meant '$self->{conf}->{arch}' ofc

> (or am i missing something else here?)
> 
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>