[pve-devel] [PATCH container] fix #4192: add new architecture-dependent path to check for newer versions of systemd

Dominik Csapak d.csapak at proxmox.com
Mon Sep 12 11:30:09 CEST 2022


[snip]
>>   
>>   # non systemd based containers work with pure cgroupv2
>>   sub unified_cgroupv2_support {
>> -    my ($self) = @_;
>> +    my ($self, $conf) = @_;
> 
> why pass the whole config if you just need the arch? Please avoid overly generic
> parameter in signatures if only one specific thing is required.
> 

AFAICS, not even that is necessary, since a 'LXC::Setup' object has the config in self
so we could do there a '$self->{confg}->{arch}' and omit the parameter passing completely
(or am i missing something else here?)







More information about the pve-devel mailing list