[pve-devel] [PATCH manager] ui: ceph: osd: set default icon for other crush types

Aaron Lauterer a.lauterer at proxmox.com
Thu Nov 17 10:29:13 CET 2022


Some users have a more complicated CRUSH hierarchy, for example with a
stretched cluster. The additional hierarchy steps (datacenter, rack,
room, ...) are shown in the OSD panel. Showing a generic icon for any
CRUSH types that have not a specific icon configured will make it easier
to navigate the tree as it will not look somewhat broken and empty.

Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
---
 www/manager6/ceph/OSD.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index 78f226ff..1255e396 100644
--- a/www/manager6/ceph/OSD.js
+++ b/www/manager6/ceph/OSD.js
@@ -847,7 +847,8 @@ Ext.define('PVE.node.CephOsdTree', {
 		osd: 'fa-hdd-o',
 		root: 'fa-server',
 	    };
-	    return 'fa x-fa-tree ' + iconMap[data.type];
+	    let icon = iconMap[data.type] ?? 'fa-folder-o';
+	    return `fa x-fa-tree ${icon}`;
 	},
 },
 	{ type: 'number', name: 'crush_weight' },
-- 
2.30.2






More information about the pve-devel mailing list