[pve-devel] applied: [PATCH widget-toolkit 1/2] api-viewer: fix #4271: display nested formats instead of [object Object]

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 17 08:30:02 CET 2022


Am 12/10/2022 um 15:23 schrieb Matthias Heiserer:
> I tried to keep the format as close to the HTML docs as possible, but there are a few discrepancies between HTML docs and how this patch displays parameters:
> Instead of <enum>,the enum variants are displayed. [1]
> Instead of <0|1>, <boolean> is displayed.
> 
> [1] The HTML docs explain parameters after the initial format string, which the GUI doesn't (and there's no space for that).
> Showing the variants inline is the easiest way to not loose information here.

please use a text-width limit of <<70 for commit message text:

https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages

I re-wrapped that on apply.


> 
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---
>  src/api-viewer/APIViewer.js | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list