[pve-devel] applied: [PATCH manager] api: backup: auto-inject job id where expected by the API

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 15 13:30:02 CET 2022


Am 15/11/2022 um 11:18 schrieb Fiona Ebner:
> for backwards compatibility. Otherwise, e.g. listing backup jobs with
> pvesh get /cluster/backup is broken. And suddenly not having the
> property anymore would be a breaking API change.
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> I didn't see any other places that rely on the $job->{id} to be set.
> The other backup-related API calls and Jobs.pm iterate or check the
> ids from the section config's $parsed->{ids}. Scheduler doesn't need
> either AFAICT.
> 
> @Dominik: I guess you need to adapt the (not-yet-applied) realm sync
> jobs API too now that the id is not auto-injected.
> 
>  PVE/API2/Backup.pm | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list