[pve-devel] [PATCH manager] api: backup: auto-inject job id where expected by the API

Fiona Ebner f.ebner at proxmox.com
Tue Nov 15 11:27:17 CET 2022


The commit message should include the why too of course rather than just
having it in the code comments:

Am 15.11.22 um 11:18 schrieb Fiona Ebner:
> for backwards compatibility.

When moving the job base plugin to pve-common, the behavior for parsing
the job config changed slightly, and 'id' was not automatically set as a
job property anymore.

> Otherwise, e.g. listing backup jobs with
> pvesh get /cluster/backup is broken. And suddenly not having the
> property anymore would be a breaking API change.
> 

Sorry for the noise.





More information about the pve-devel mailing list