[pve-devel] [PATCH proxmox/backup/common/storage/wt] add tar.zst download in pve

Dominik Csapak d.csapak at proxmox.com
Tue May 31 13:17:19 CEST 2022

like we have the tar.zst download button for pbs itself, add it for
pve for both vms and container file-restore

pve-storage depends on pve-common, which depends on proxmox-backup,
which depends on proxmox
(we must bump proxmox-compression and add the new version as a
dependency; also for the restore-daemon)

widget-toolkit could be done differently (just set enableTar to true;
either by default or in proxmox-backup), but since we don't use
it anywhere else, this seemed wrong

also i am not completely happy with the interface: i added a 'tar' parameter
to the download path (for gui compatibility) and to the file-restore
binary, but moved to a 'format' parameter in the restore-daemon.

i'd really prefer to have a single parameter style for that, but i did not want
to pass through the 'tar' through all layers, and moving all to a 'format'
parameter would be more work (api compatibility etc.). so maybe someone else has
another take on, which way i should pursue in a v2?

also AFAICS, the restore-daemon and file-restore binary always go
together, so do we have to keep the api of the restore-daemon
compatible ? (theoretically users could invoke that manually?)


Dominik Csapak (2):
  proxmox-compression: make ZstdEncoder stream a bit more generic
  proxmox-compression: add 'tar_directory'

 proxmox-compression/Cargo.toml  |   1 +
 proxmox-compression/src/tar.rs  | 116 ++++++++++++++++++++++++++++++++
 proxmox-compression/src/zstd.rs |  15 +++--
 3 files changed, 127 insertions(+), 5 deletions(-)


Dominik Csapak (2):
  restore-daemon: add 'format' parameter to the 'extract' handler
  file-restore: add 'tar' option to 'extract' command

 proxmox-file-restore/Cargo.toml               |  1 +
 proxmox-file-restore/src/block_driver.rs      |  6 +--
 proxmox-file-restore/src/block_driver_qemu.rs |  4 +-
 proxmox-file-restore/src/main.rs              | 51 ++++++++++++++-----
 .../src/proxmox_restore_daemon/api.rs         | 49 +++++++++++++++---
 5 files changed, 88 insertions(+), 23 deletions(-)


Dominik Csapak (1):
  PBSClient: add 'tar' parameter to file_restore_extract

 src/PVE/PBSClient.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Dominik Csapak (1):
  api/filerestore: add 'tar' parameter to 'download' api

 PVE/API2/Storage/FileRestore.pm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)


Dominik Csapak (1):
  window/FileBrowser: enable tar button by default

 src/window/FileBrowser.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)


More information about the pve-devel mailing list