[pve-devel] [PATCH pve-cluster] Change log statements to debug

Matthias Heiserer m.heiserer at proxmox.com
Fri May 27 11:37:25 CEST 2022


They have been commented with //fixme for more than 11 years
and contain little information, so at least make them debug logs.

Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
---
 data/src/logger.c | 2 +-
 data/src/status.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/data/src/logger.c b/data/src/logger.c
index 619e1f6..c4fcdaa 100644
--- a/data/src/logger.c
+++ b/data/src/logger.c
@@ -626,7 +626,7 @@ clusterlog_insert(
 	if (dedup_lookup(cl->dedup, entry)) {
 		clog_copy(cl->base, entry);
 	} else {
-		cfs_message("ignore duplicate"); // fixme remove
+		cfs_debug("ignore duplicate"); // fixme remove
 	}
 
 	g_mutex_unlock(&cl->mutex);
diff --git a/data/src/status.c b/data/src/status.c
index 9bceaeb..5e39109 100644
--- a/data/src/status.c
+++ b/data/src/status.c
@@ -1668,7 +1668,7 @@ dfsm_deliver(
 			cfs_critical("cant parse update message");
 		}
 	} else if (msg_type == KVSTORE_MESSAGE_LOG) {
-		cfs_message("received log"); // fixme: remove
+		cfs_debug("received log"); // fixme: remove
 		const clog_entry_t *entry;
 		if ((entry = kvstore_parse_log_message(msg, msg_len))) {
 			clusterlog_insert(cfs_status.clusterlog, entry);
-- 
2.30.2





More information about the pve-devel mailing list