[pve-devel] applied: [PATCH common] tools: use int() on all integer syscall parameters

Thomas Lamprecht t.lamprecht at proxmox.com
Fri May 20 15:16:43 CEST 2022


On 17/05/2022 14:40, Wolfgang Bumiller wrote:
> this should fix an issue where users with custom id mappings
> get bad ownership on intermediate directories caused by the
> rootuid/gid being the string "100000" in perl instead of the
> number 100000...
> 
> Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
> ---
> NOTE: I decided to go through them all, not just `fchownat` which was
> currently problematic (most likely the issue of [1]).
> 
> I hope I got them all right.
> 
> This was a frustrating one.
> 
> pve needs more rust...

+1

> 
> [1] https://forum.proxmox.com/threads/restoring-lxc-from-pbs-fails.108905/#post-471509
> 
>  src/PVE/Tools.pm | 91 ++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 65 insertions(+), 26 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list