[pve-devel] [PATCH v5 manager] ui: vm network: allow to override MTU for virtio devices

Oguz Bektas o.bektas at proxmox.com
Fri May 20 10:03:56 CEST 2022


On Fri, May 20, 2022 at 09:41:10AM +0200, Thomas Lamprecht wrote:
> On 19/05/2022 10:48, Oguz Bektas wrote:
> > we already have the 'mtu' option in the API, so we can just expose
> > that option inside the 'Advanced' menu for virtio network interfaces.
> > 
> > Reviewed-By: Aaron Lauterer <a.lauterer at proxmox.com>
> > Tested-By: Aaron Lauterer <a.lauterer at proxmox.com>
> > Tested-By: Dylan Whyte <d.whyte at proxmox.com>
> 
> aren't those from two version previous with some change in between, or
> did they re-test / re-review this in private?
> As IMO it's not really correct to let one believe that this exact version
> was tested by two people.

sorry for the confusion, the tags were leftover from the previous
commits

> 
> Functionality wise it looks Ok, a few final layout and code style nits
> I'd still like to see inline.


i've addressed the nits in the v6.

though i don't think the 
> "Use the special value '1' to inherit the MTU from the underlying bridge"
is the best, since the user won't see this message until they've
selected '1' as a value.

regardless, i've made the changes you asked for

- oguz




More information about the pve-devel mailing list