[pve-devel] [PATCH v3 manager 1/2] HDEdit: check iothread by default and move it from advanced section

Fabian Ebner f.ebner at proxmox.com
Wed May 18 11:40:02 CEST 2022


Am 12.05.22 um 11:24 schrieb Matthias Heiserer:
> Existing disks are not changed by this.
> Especially in benchmarks, iothreads significantly improve IO performance.
> 
> 
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---
> 
> Changes from v2:
> * also check iothread when adding a disk to an existing VM and 
>  scsi single
> * use bind instead of hardcoded true

This feels like to much automagic to me, because changes to the checkbox
(even if checkbox is for a virtio disk) will change the controller type
and vice versa. This also makes it impossible to only set iothread on
certain disks or use the "Virtio SCSI single" controller type without
setting iothread.

Is it possible to instead have the checkbox be invalid with an
appropriate error for the user when it's a bad configuration?




More information about the pve-devel mailing list