[pve-devel] [PATCH common 2/2] REST environment: default to 'root at pam' for forked workers in case no user was specified

Fabian Ebner f.ebner at proxmox.com
Fri Mar 11 09:00:50 CET 2022


Am 10.03.22 um 13:01 schrieb Fabian Ebner:
> Am 07.03.22 um 10:20 schrieb Oguz Bektas:
>> +    if (!defined($user)) {
>> +	warn 'Worker user was not specified, defaulting to "root at pam"!';
> 
> Could mention that it's an internal error. And could use $self->warn().

Shouldn't use $self->warn(), because the warning here won't show up in
the task log and it'd be very confusing to have a non-zero warning count
without warning.





More information about the pve-devel mailing list