[pve-devel] [PATCH v3 manager 0/4] ui: lxc/qemu: add reassign for disks and volumes
Aaron Lauterer
a.lauterer at proxmox.com
Mon Mar 7 11:07:18 CET 2022
This series adds the UI to reassign a disk / volume from one guest to another.
To avoid button clutter, the Move, Reassing and Resize buttons are moved
into a new submenu called "Disk/Volume Action".
Patch 2 to 4 are optional. Patch 2 changes the labels for Move, Reassign
and Resize to remove Volume & Disk as we already have this in the
context of the submenu.
Patch 3 only changes a double negated option and patch 4 happend in the
process of working on an interface for the reassign functionality. Since
the work of modernizing this componend is done, why not use it
v3:
* change to Edit window, removing quite some boilerplate code
* create new submenu for disk/volume actions
* incorporate smaller style nits
* simplify other labels as well, removing 'Volume' and 'Disk' as the
context gives that away already
v2: incorporated feedback I got off list, mainly
* using more modern approaches
* more arrow functions
* reducing use of predefined cbind values and using inline functions
when possible
Aaron Lauterer (4):
ui: lxc/qemu: add disk reassign and action submenu
ui: lxc/qemu: disk/volume action simplify menu items
ui: BusTypeSelector: change noVirtIO to withVirtIO
ui: hdmove: modernize/refactor
www/manager6/Makefile | 1 +
www/manager6/form/BusTypeSelector.js | 4 +-
www/manager6/form/ControllerSelector.js | 4 +-
www/manager6/lxc/Resources.js | 66 ++++--
www/manager6/qemu/CDEdit.js | 2 +-
www/manager6/qemu/CIDriveEdit.js | 2 +-
www/manager6/qemu/HDMove.js | 192 ++++++++---------
www/manager6/qemu/HDReassign.js | 274 ++++++++++++++++++++++++
www/manager6/qemu/HardwareView.js | 65 +++++-
9 files changed, 476 insertions(+), 134 deletions(-)
create mode 100644 www/manager6/qemu/HDReassign.js
--
2.30.2
More information about the pve-devel
mailing list