[pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids

Nicholas Sherlock nick at nicksherlock.com
Thu Jan 20 22:21:25 CET 2022


On Fri, 21 Jan 2022, 4:48 am Dominik Csapak, <d.csapak at proxmox.com> wrote:

> 2 nits left (you could send a v3, or we can fix it up, please
> write what you prefer)
>
> * the commit message should not have lines longer than 70 characters[0]
> * and the gettext is not optimal, i'd omit the  'Set ' prefix (sorry i did
> not
>    catch it the first time), so 'Vendor ID' instead of 'Set vendor ID'
>

I would recommend keeping the "set" text in, because otherwise it makes it
look like you can pick which host device you want to pass through by using
those fields. I think it could confuse people.

Happy for you to fix the patch as needed

Cheers,
Nick



> otherwise:
>
> Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
> Tested-by: Dominik Csapak <d.csapak at proxmox.com>
>
> 0:
> https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>


More information about the pve-devel mailing list