[pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids

Dominik Csapak d.csapak at proxmox.com
Thu Jan 20 16:48:33 CET 2022


On 1/18/22 22:38, Nicholas Sherlock wrote:
> In this version, changed proposed x-pci-device-id names to remove x-pci- prefix to shorten configs, and improved Perl code style, thanks to Dominik Csapak
> 
> [PATCH v2 qemu-server] pci: allow override of PCI vendor/device ids
> [PATCH v2 pve-manager] ui: pci passthrough: editor for pci-id
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 

Thanks,

2 nits left (you could send a v3, or we can fix it up, please
write what you prefer)

* the commit message should not have lines longer than 70 characters[0]
* and the gettext is not optimal, i'd omit the  'Set ' prefix (sorry i did not
   catch it the first time), so 'Vendor ID' instead of 'Set vendor ID'

otherwise:

Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
Tested-by: Dominik Csapak <d.csapak at proxmox.com>

0: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages




More information about the pve-devel mailing list