[pve-devel] [PATCH manager] storage GUI: fix unintuitive sorting order

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Feb 21 09:39:45 CET 2022


On 21.02.22 09:32, Fabian Ebner wrote:
> Am 18.02.22 um 11:42 schrieb Matthias Heiserer:
>> The backups in the 'Backups' table in Storages are now initially
>> sorted by column 'Name' ascending.
>>
>> Previously, they were first sorted by 'vmid' descending, then by date
>> descending. This was unintuitive as 'vmid' doesn't exist as column
>> in the GUI, and only 'Date' displayed a sorting arrow.
>>
>> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
>> ---
>>  www/manager6/storage/BackupView.js | 6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>
> Please note that the order was recently intentionally changed to be like
> that, see commit 58f4e6ac387561a16ec370812083d60a12dc4cfe
> 
> That said, you do have a point. One way to improve the situation might
> be to add a vmid column, but we could also think about using a tree view
> for backups instead.
>> @Thomas: Would the latter be okay for you?

A tree view like PBS has would be nice in general IMO for the storage
backup content view, as with lots of VMs that's way easier to browse/work
with than the flat list. IIRC we talked about that already in the past,
in the context of the prune group button, but it wasn't to pressing then
and went off the radar.

Adding the vmid, at least as by-default hidden column, would be the easiest
(quickest) change now though, but this is IMO not to pressing that we need
to do any stop-gap measures.





More information about the pve-devel mailing list