[pve-devel] applied: [PATCH qemu-server] clone disk: force raw format for TPM state

[Fabian Ebner]

Am 17.02.22 um 14:33 schrieb Thomas Lamprecht:
> On 16.02.22 11:47, Fabian Ebner wrote:
>> The format can't be qcow2 for TPM state, because swtpm reads the file
>> directly expecting raw data.
>>
>> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
>> ---
>>
>> The DiskStorageSelector in the UI hides the format for TPM state, but
>> still sends along format=qcow2 triggering this bug. Still, the fix
>> should be in the backend.
>>
> 
> IMO the frontend shouldn't send that though and in a next major version the backend
> should bail on that, as it can be confusing to do such things "magically".
> 

AFAICT the format parameter for disks is mostly (always?) treated as a
suggestion and quietly ignored if the storage doesn't support it. It
happens for clone (not limited to tpmstate0), allocation via pvesm
alloc, allocation via special <storeid>:0 syntax, importdisk.

Of course fixing the frontend for tpmstate0 still makes sense, but I
wonder if all of the above should be changed then?

>>  PVE/QemuServer.pm | 1 +
>>  1 file changed, 1 insertion(+)
>>
>>
> 
> applied, thanks!