[pve-devel] applied: [PATCH v4 manager] api: apt: repos: fix interfacing with perlmod

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Feb 17 14:34:54 CET 2022


On 16.07.21 15:27, Fabian Ebner wrote:
> Using
>     pvesh create /nodes/pve701/apt/repositories --path
>     "/etc/apt/sources.list" --index 0 --enabled 1
> reliably leads to
>     error: invalid type: string "0", expected usize
> 
> Coerce to int to avoid this. I was not able to trigger the issue with
> the "enabled" option being a string here (in PMG I was), but be on the
> safe side and coerce there too. Otherwise it might get triggered by a
> future, completely unrelated change further up in the API call
> handling.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> Changes from v3:
>     * shorter/cleaner code, but now there's no good reason for the
>       comment anymore, because it's arguably the better code even
>       without the perlmod limitation. But I do have a reproducer, so
>       hopefully the issue can be fixed in perlmod before somebody else
>       runs into it.
> 
>  PVE/API2/APT.pm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
>

sorry I thought this was already done, now applied, thanks!





More information about the pve-devel mailing list