[pve-devel] [PATCH v2 manager] ui: vm network: allow to override MTU for virtio devices

[Oguz Bektas]

On Thu, Feb 10, 2022 at 02:53:19PM +0100, Aaron Lauterer wrote:
> Looks good AFAICT and does what we want.
> 
> We could improve it further by adding a small validator. Otherwise the user will only notice their error once they get the error msg from the API.
> 
> A quick way that I came up with that could potentially be done better:
> 
> diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
> index 1e34ad1c..2566d1a8 100644
> --- a/www/manager6/qemu/NetworkEdit.js
> +++ b/www/manager6/qemu/NetworkEdit.js
> @@ -184,6 +184,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>                 bind: {
>                     disabled: '{!isVirtio}',
>                 },
> +               validator: function(value) {
> +                   if (value === "" || (value > 0 && value <= 65520)) {
> +                       return true;
> +                   } else {
> +                       return gettext("must be between 0 and 65520");
> +                   }
> +               },
>                 allowBlank: true,
>             },
>         ];
> 
> 
> Besides this last improvement:
> 
> Reviewed-By: Aaron Lauterer <a.lauterer at proxmox.com>
> Tested-By: Aaron Lauterer <a.lauterer at proxmox.com>
> 

thanks for the test and review!

instead of a validator function i guess we could just set minValue and
maxValue as well? (since allowBlank is set to true)

seemed to work fine in my short testing just now :)

diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index 1e34ad1c..a3fa5724 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -184,6 +184,8 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
 		bind: {
 		    disabled: '{!isVirtio}',
 		},
+		minValue: 1,
+		maxValue: 65520,
 		allowBlank: true,
 	    },
 	];