[pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices

[Oguz Bektas]

hi,

thx for the review :)

On Wed, Feb 09, 2022 at 07:03:34PM +0100, Thomas Lamprecht wrote:
> commit subject should rather be
> 
> "ui: vm network: allow to override mtu for virtio devices"

okay

> 
> On 07.02.22 13:18, Oguz Bektas wrote:
> > we already have the 'mtu' option inside the API, so we can just expose
> > that option inside the 'Advanced' menu for guest network interfaces.
> 
> We have that property since commit 61a14cde8d568e552d3deaab2da76b479b8aca7b but
> it's only effective for when the VirtIO driver is used. The ui should reflect
> that as it may get really confusing for users with e1000(e) or other non-virtio
> models. MTU changes are notoriously tricky as it needs to be right in the whole
> network path, so the UX is IMO important for this

ah that's true! i'll send in a v2 :)