[pve-devel] [PATCH manager v2 1/1] ui: realm sync: replace 'full' with 'mode'

Dominik Csapak d.csapak at proxmox.com
Fri Feb 4 15:25:01 CET 2022


in default sync options and the sync window. since we get the
mapped mode from the backend on read, a 'full=1' there will map
to 'mode=full' and we can simply use that

using this on a node with an old version will not work though

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/dc/AuthEditLDAP.js | 11 ++++++-----
 www/manager6/dc/SyncWindow.js   |  9 +++++----
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/www/manager6/dc/AuthEditLDAP.js b/www/manager6/dc/AuthEditLDAP.js
index 015a5a6e..bb50e21b 100644
--- a/www/manager6/dc/AuthEditLDAP.js
+++ b/www/manager6/dc/AuthEditLDAP.js
@@ -100,7 +100,7 @@ Ext.define('PVE.panel.LDAPSyncInputPanel', {
     xtype: 'pveAuthLDAPSyncPanel',
 
     editableAttributes: ['email'],
-    editableDefaults: ['scope', 'full', 'enable-new', 'purge'],
+    editableDefaults: ['scope', 'mode', 'enable-new', 'purge'],
     default_opts: {},
     sync_attributes: {},
 
@@ -210,11 +210,12 @@ Ext.define('PVE.panel.LDAPSyncInputPanel', {
 	    deleteEmpty: false,
 	    comboItems: [
 		['__default__', Proxmox.Utils.NoneText],
-		['1', Proxmox.Utils.yesText],
-		['0', Proxmox.Utils.noText],
+		['update', gettext('Update')],
+		['sync', gettext('Sync')],
+		['full', gettext('Full')],
 	    ],
-	    name: 'full',
-	    fieldLabel: gettext('Full'),
+	    name: 'mode',
+	    fieldLabel: gettext('Mode'),
 	},
     ],
 
diff --git a/www/manager6/dc/SyncWindow.js b/www/manager6/dc/SyncWindow.js
index 25a42182..2eeaf572 100644
--- a/www/manager6/dc/SyncWindow.js
+++ b/www/manager6/dc/SyncWindow.js
@@ -95,11 +95,12 @@ Ext.define('PVE.dc.SyncWindow', {
 			deleteEmpty: false,
 			allowBlank: false,
 			comboItems: [
-			    ['1', Proxmox.Utils.yesText],
-			    ['0', Proxmox.Utils.noText],
+			    ['update', gettext('Update')],
+			    ['sync', gettext('Sync')],
+			    ['full', gettext('Full')],
 			],
-			name: 'full',
-			fieldLabel: gettext('Full'),
+			name: 'mode',
+			fieldLabel: gettext('Mode'),
 		    },
 		],
 
-- 
2.30.2






More information about the pve-devel mailing list