[pve-devel] [PATCH v10 manager 02/19] ui: HD edit: get rid of unneeded binding for backup checkbox

Fabian Ebner f.ebner at proxmox.com
Wed Apr 6 10:03:59 CEST 2022


In preparation to move the advanced options to their own tab, where
the value would not be updated until the component is rendered, which
might not happen before submitting.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
 www/manager6/qemu/HDEdit.js | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index c643ee73..89620e7f 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -57,9 +57,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 
 	init: function(view) {
 	    var vm = this.getViewModel();
-	    if (view.isCreate) {
-		vm.set('isIncludedInBackup', true);
-	    }
+
 	    if (view.confid) {
 		vm.set('isSCSI', view.confid.match(/^scsi/));
 		vm.set('isVirtIO', view.confid.match(/^virtio/));
@@ -293,9 +291,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		    'data-qtip': gettext('Include volume in backup job'),
 		},
 		name: 'backup',
-		bind: {
-		    value: '{isIncludedInBackup}',
-		},
+		value: me.isCreate,
 	    },
 	    {
 		xtype: 'proxmoxcheckbox',
-- 
2.30.2






More information about the pve-devel mailing list