[pve-devel] [PATCH v10 manager 03/19] ui: HD edit: move advanced options into a dedicated tab

[Fabian Ebner]

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
 www/manager6/qemu/HDEdit.js | 31 +++++++++++--------------------
 1 file changed, 11 insertions(+), 20 deletions(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index 89620e7f..92e6d116 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -170,8 +170,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	me.down('#hdimage').setStorage(undefined, nodename);
     },
 
-    hasAdvanced: true,
-
     initComponent: function() {
 	var me = this;
 
@@ -180,9 +178,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	let column1 = [];
 	let column2 = [];
 
-	let advancedColumn1 = [];
-	let advancedColumn2 = [];
-
 	if (!me.confid || me.unused) {
 	    me.bussel = Ext.create('PVE.form.ControllerSelector', {
 		vmconfig: me.vmconfig,
@@ -251,7 +246,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	    },
 	);
 
-	advancedColumn1.push(
+	let optionsColumn1 = [
 	    {
 		xtype: 'proxmoxcheckbox',
 		fieldLabel: gettext('SSD emulation'),
@@ -280,9 +275,9 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		    disabled: '{!isVirtIO && !isSCSI}',
 		},
 	    },
-	);
+	];
 
-	advancedColumn2.push(
+	let optionsColumn2 = [
 	    {
 		xtype: 'proxmoxcheckbox',
 		fieldLabel: gettext('Backup'),
@@ -311,7 +306,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		    ['threads', 'threads'],
 		],
 	    },
-	);
+	];
 
 	let labelWidth = 140;
 
@@ -403,21 +398,22 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		    {
 			title: gettext('Disk'),
 			xtype: 'inputpanel',
-			reference: 'diskpanel',
 			column1,
 			column2,
-			advancedColumn1,
-			advancedColumn2,
-			showAdvanced: me.showAdvanced,
+			getValues: () => ({}),
+		    },
+		    {
+			title: gettext('Options'),
+			xtype: 'inputpanel',
+			column1: optionsColumn1,
+			column2: optionsColumn2,
 			getValues: () => ({}),
 		    },
 		    {
 			title: gettext('Bandwidth'),
 			xtype: 'inputpanel',
-			reference: 'bwpanel',
 			column1: bwColumn1,
 			column2: bwColumn2,
-			showAdvanced: me.showAdvanced,
 			getValues: () => ({}),
 		    },
 		],
@@ -426,11 +422,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
 
 	me.callParent();
     },
-
-    setAdvancedVisible: function(visible) {
-	this.lookup('diskpanel').setAdvancedVisible(visible);
-	this.lookup('bwpanel').setAdvancedVisible(visible);
-    },
 });
 
 Ext.define('PVE.qemu.HDEdit', {
-- 
2.30.2