[pve-devel] [PATCH storage] fix #3610: properly build ZFS detail tree

[Thomas Lamprecht]

On 10.09.21 10:03, Fabian Ebner wrote:
> Am 09.09.21 um 18:24 schrieb Thomas Lamprecht:
>> hmm, I get the idea and can see how one could assert that this is more correct,
>> but as it is presented it'd be a bit more confusing too, IMO, as it does not
>> matches the zpool status CLI output anymore.
>>
>> I.e., the following (real):
>>>          NAME                                      STATE     READ WRITE CKSUM
>>>          zpt                                       ONLINE       0     0     0
>>>            mirror-0                                ONLINE       0     0     0
>>>              scsi-0QEMU_QEMU_HARDDISK_drive-scsi3  ONLINE       0     0     0
>>>              scsi-0QEMU_QEMU_HARDDISK_drive-scsi4  ONLINE       0     0     0
>>>          logs
>>>            scsi-0QEMU_QEMU_HARDDISK_drive-scsi5    ONLINE       0     0     0
>>
>>
>> Is suggested to be (adapted):
>>>          NAME                                      STATE     READ WRITE CKSUM
>>>          zpt                                       ONLINE
>>>            zpt                                       ONLINE       0     0     0
>>>              mirror-0                                ONLINE       0     0     0
>>>                scsi-0QEMU_QEMU_HARDDISK_drive-scsi3  ONLINE       0     0     0
>>>                scsi-0QEMU_QEMU_HARDDISK_drive-scsi4  ONLINE       0     0     0
>>>          logs
>>>            scsi-0QEMU_QEMU_HARDDISK_drive-scsi5    ONLINE       0     0     0
>>
> 
> Is 'logs' aligned with the outer 'zpt' or the inner 'zpt'? It's intended to be the inner one, but in the mail it looks like the outer one to me.
> 

inner, so that's OK and will keep that way if we drop the root node.

>>
>> How about hiding the root in the devices tree and add a line to the
>> KV grid above instead? E.g., something that would then render:
>>
>> Pool       <ID> (<STATUS>)
>>
>> That can be a GUI change only, did not really checked implementation details, but
>> I'd like to clear that up before applying this patch.
>>
> 
> I suppose that should be done for PBS too then? And PVE should switch to using the ZFSDetail window from widget-toolkit?

yes to both (ideally).