[pve-devel] [PATCH qemu-server] fix removing cpulimit on running vm

[Oguz Bektas]

On Thu, Oct 21, 2021 at 04:21:12PM +0200, Dominik Csapak wrote:
> On 10/21/21 13:43, Oguz Bektas wrote:
> > On Thu, Oct 21, 2021 at 12:51:43PM +0200, Dominik Csapak wrote:
> > > On 10/21/21 11:53, Oguz Bektas wrote:
> > > > hi,
> > > > 
> > > > works for cgroupv2 but with 'systemd.unified_cgroup_hierarchy=0' in
> > > > cmdline it errors:
> > > > 
> > > > 
> > > > ====
> > > > update VM 101: -delete cpulimit
> > > > 400 Parameter verification failed.
> > > > cpulimit: hotplug problem - closing file
> > > > '/sys/fs/cgroup/cpu/qemu.slice/101.scope//cpu.cfs_period_us' failed -
> > > > Invalid argument
> > > > ====
> > > > 
> > > > 
> > > 
> > > hm... does this work for running containers? since we use the
> > > exact same code there for cpulimit...
> > 
> > apparently doesn't work there either
> > 
> 
> ok i guess then we should fix it in pve-common and keep this patch as is?
> 
yep i've sent patch for pve-common now, with that applied your fix works

Tested-by: Oguz Bektas <o.bektas at proxmox.com>
Reviewed-by: Oguz Bektas <o.bektas at proxmox.com>