[pve-devel] [PATCH manager v3 0/7] multi disk/mp in wizard

Aaron Lauterer a.lauterer at proxmox.com
Wed Oct 20 12:10:02 CEST 2021


Works quite well :)

Tested it on Chromium also in different zoom levels. I encountered a few minor glitches. When I added the max amount of disks / mount points and removed them in rapid succession, the scrolling would get messed up sometimes:
- horizontally a bit too wide with the delete button halfway hidden behind the scrollbar
- vertically a lot of empty space above the actual list

could be caused by the different zoom factor and extjs getting a bit confused. Usually those glitches were resolved by either removing a few more disks or by scrolling all the down/up.

When adding all possible mount points for a container, the GUI gets quite sluggish.
Also, the max mount points is 256 but I was only able to create mp0 to mp254. Unless the rootfs is also counted against that number, I would expect to be able to create mp0 to mp255. But did not investigate further and my assumption could be just wrong.

Besides that it works as expected and will definitely make life easier in certain situations.

Tested-By: Aaron Lauterer <a.lauterer at proxmox.com>

On 10/5/21 13:28, Dominik Csapak wrote:
> this series is a continuation of my previous multi tab / disk series[0]
> 
> Introduces multi disk panels for vm and containers in the wizard.
> 
> The UX is modeled after Dominics first attempt, but a very different
> approach code-wise. instead of having a seperate 'data' panel that
> contains the vm config, let the multi disk panel handle that
> and pass it through to the panels below. this way the HDEdit does
> not need a big code-change to get/set the config.
> 
> changes from v2:
> * rebase on master (multi tab disk panel already applied)
> * refactor multi disk panel so that we can reuse it for containers
> * implement multi mp panel for container
> 
> changes from v1:
> * fixed a bug which prevented the wizard from finishing
> * made the wizard a little wider so that the form field labes are
>    readable
> * added logic to use the ostype to determine the first disk if one
>    deleted all before
> 
> 0: https://lists.proxmox.com/pipermail/pve-devel/2021-October/050215.html
> 
> Dominik Csapak (7):
>    ui: lxc/MPEdit: add updateVMConfig
>    ui: lxc/MPEdit: fire diskidchange event
>    ui: lxc/MPEdit: add selectFree toggle
>    ui: add MultiDiskPanel
>    ui: add lxc/MultiMPEdit and use in lxc/CreateWizard
>    ui: add qemu/MultiHDEdit and use it in the wizard
>    ui: window/Wizard: make it a little wider
> 
>   www/manager6/Makefile               |   3 +
>   www/manager6/lxc/CreateWizard.js    |   8 +-
>   www/manager6/lxc/MPEdit.js          |  16 +-
>   www/manager6/lxc/MultiMPEdit.js     |  79 ++++++++
>   www/manager6/panel/MultiDiskEdit.js | 272 ++++++++++++++++++++++++++++
>   www/manager6/qemu/CreateWizard.js   |   7 +-
>   www/manager6/qemu/HDEdit.js         |   9 +-
>   www/manager6/qemu/MultiHDEdit.js    |  62 +++++++
>   www/manager6/window/Wizard.js       |   2 +-
>   9 files changed, 444 insertions(+), 14 deletions(-)
>   create mode 100644 www/manager6/lxc/MultiMPEdit.js
>   create mode 100644 www/manager6/panel/MultiDiskEdit.js
>   create mode 100644 www/manager6/qemu/MultiHDEdit.js
> 




More information about the pve-devel mailing list